Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Fix path to .eslintignore in build exclusions - #13701

Merged
jeremyn merged 1 commit into
EFForg:masterfrom
Bisaloo:fix-build-exclusions
Nov 22, 2017
Merged

jeremyn merged 1 commit into
EFForg:masterfrom
Bisaloo:fix-build-exclusions

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Nov 22, 2017

Copy link
Copy Markdown
Collaborator

.eslintignore is added to the packaged extension (see here). It was added to build_exclusions in #13560 but it looks like the path was wrong.

@Hainish @jeremyn

@jeremyn
jeremyn merged commit 54b659d into EFForg:master Nov 22, 2017
@Bisaloo
Bisaloo deleted the fix-build-exclusions branch November 22, 2017 15:34
@jeremyn

jeremyn commented Nov 22, 2017

Copy link
Copy Markdown
Contributor

I did that, sorry. Thanks for fixing it.

Based on a closer reading of the code -- make.sh, utils/create_xpi.py, and utils/zipfile_deterministic.write_from_directory -- it looks like pkg/crx/ is the root directory for .build_exclusions, and pkg/crx/ is first rsync'd from chromium/, so really chromium/ is the root for .build_exclusions. Is that right?

@Bisaloo

Bisaloo commented Nov 22, 2017

Copy link
Copy Markdown
Collaborator Author

Yes, I think so. I also built the xpi from this branch and .eslintignore was indeed gone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants